From: Oliver Hartkopp <socketcan@hartkopp•net>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
linux-can@vger•kernel.org
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH RFC v2 1/2] can: fix multiple delivery of a single CAN frame for overlapping CAN filters
Date: Mon, 30 Mar 2015 17:49:34 +0200 [thread overview]
Message-ID: <5519708E.3040002@hartkopp.net> (raw)
In-Reply-To: <5519429A.8050000@cogentembedded.com>
On 30.03.2015 14:33, Sergei Shtylyov wrote:
> On 3/29/2015 9:09 PM, Oliver Hartkopp wrote:
>>
>> + /* eliminate multiple filter matches for the same skb */
>> + if (*this_cpu_ptr(ro->uniq_skb) == oskb &&
>> + ktime_equal(*this_cpu_ptr(ro->uniq_tstamp), oskb->tstamp)) {
>> + return;
>
> Over-indented.
>
I was asked about that before. AFAIK the *skb is no unique identifier over a
longer period of time. But together with the timestamp it becomes unique.
Or do you have a better solution to detect identical skbs?
CAN skbs do not have a (rx)hash so far and I wonder if it's worth to compute
the hash in favor to check the *skb and the timestamp here ...
>> +
>> + ro->uniq_tstamp = alloc_percpu(ktime_t);
>> + if (unlikely(ro->uniq_tstamp == NULL)) {
>
> !ro->uniq_tstamp is preferred in the networking code.
>
Ok. Will change that.
Best regards,
Oliver
> [...]
>
> WBR, Sergei
>
next prev parent reply other threads:[~2015-03-30 15:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-29 18:09 [PATCH RFC v2 0/2] can: join filters with per-CPU variables Oliver Hartkopp
2015-03-29 18:09 ` [PATCH RFC v2 1/2] can: fix multiple delivery of a single CAN frame for overlapping CAN filters Oliver Hartkopp
2015-03-30 9:50 ` Marc Kleine-Budde
2015-03-30 10:29 ` Oliver Hartkopp
2015-03-30 10:36 ` Marc Kleine-Budde
2015-03-30 10:10 ` Marc Kleine-Budde
2015-03-30 10:16 ` Marc Kleine-Budde
2015-03-30 10:41 ` Oliver Hartkopp
2015-03-31 12:32 ` Marc Kleine-Budde
2015-03-31 20:24 ` Oliver Hartkopp
2015-03-30 12:33 ` Sergei Shtylyov
2015-03-30 15:49 ` Oliver Hartkopp [this message]
2015-03-30 17:14 ` Sergei Shtylyov
2015-03-30 17:25 ` Oliver Hartkopp
2015-03-29 18:09 ` [PATCH RFC v2 2/2] can: introduce new raw socket option to join the given " Oliver Hartkopp
2015-03-31 12:36 ` Marc Kleine-Budde
2015-03-31 20:30 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5519708E.3040002@hartkopp.net \
--to=socketcan@hartkopp$(echo .)net \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox