Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

From: Nicolas Ferre <[email-masked]>
Date: Fri, 3 Apr 2015 10:43:40 +0200

Le 31/03/2015 10:56, Nicolas Ferre a écrit :
> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> the macb1 interface refuses to work properly because it tries
> to cling to address 0 which isn't able to communicate in broadcast with
> the mac anymore. The micrel phy on the board is actually configured
> to show up at address 1.
> Adding the phy node and its real address fixes the issue.
> 
> Signed-off-by: Nicolas Ferre <[email-masked]>
> Cc: Johan Hovold <[email-masked]>
> Cc: <[email-masked]> #3.19
> ---

Arnd, Olof, Kevin,

It seems late but, is it possible to queue this patch as a 4.0 fixes?

Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
by u-boot previously.

Bye,

>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index fec1fca2ad66..6c4bc53cbf4e 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -167,7 +167,13 @@
>  
>  			macb1: ethernet@f802c000 {
>  				phy-mode = "rmii";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				status = "okay";
> +
> +				ethernet-phy@1 {
> +					reg = <0x1>;
> +				};
>  			};
>  
>  			dbgu: serial@ffffee00 {
> 

-- 
Nicolas Ferre