From: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public•gmane.org>
To: Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public•gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public•gmane.org>,
Jamal Hadi Salim <jhs-jkUAjuhPggJWk0Htik3J/w@public•gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH net-next] tc: cls_bpf: make ingress and egress qdiscs consistent
Date: Sat, 04 Apr 2015 08:34:06 +0200 [thread overview]
Message-ID: <551F85DE.3010804@iogearbox.net> (raw)
In-Reply-To: <551F2CD4.2080502-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
On 04/04/2015 02:14 AM, Alexei Starovoitov wrote:
> On 4/3/15 4:48 PM, Daniel Borkmann wrote:
>> On 04/04/2015 01:26 AM, Daniel Borkmann wrote:
>>> On 04/04/2015 01:11 AM, Alexei Starovoitov wrote:
>> ...
>>>> nope. will take it back.
>>>> that doesn't work, since this check cannot be done in ingress_enqueue(),
>>>> because it sees the pointer to first filter only, so both TCQ_F_INGRESS
>>>> flag and CLS_REQUIRES_L2 flag need to be checked inside
>>>
>>> So on a quick glance, we're calling into cls_bpf_classify() in
>>> tp->classify()
>>> (net/sched/cls_api.c +265), so all remaining filters in that list we're
>>> traversing in cls_bpf_classify() are all BPF filters, no?
>>
>> I see, you mean the classifier chain, not the chain of filters within
>> the cls_bpf classifier, ok.
>
> yes. the chain of classifiers can have different types, so we
> cannot check it once in ingress_enqueue().
> As you said we can refactor it later.
Too many indirections. :/ Yes, I'm fine with that, thanks.
next prev parent reply other threads:[~2015-04-04 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 21:16 [PATCH net-next] tc: cls_bpf: make ingress and egress qdiscs consistent Alexei Starovoitov
[not found] ` <1428095784-7091-1-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-04-03 21:46 ` Daniel Borkmann
[not found] ` <551F0A1B.3000100-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2015-04-03 21:52 ` Alexei Starovoitov
[not found] ` <551F0B96.2090403-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-04-03 22:10 ` Daniel Borkmann
[not found] ` <551F0FE2.8000502-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2015-04-03 22:17 ` Alexei Starovoitov
2015-04-03 22:54 ` Daniel Borkmann
[not found] ` <551F1A14.7080205-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>
2015-04-03 23:04 ` Alexei Starovoitov
2015-04-03 23:11 ` Alexei Starovoitov
[not found] ` <551F1E13.8050508-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-04-03 23:26 ` Daniel Borkmann
2015-04-03 23:48 ` Daniel Borkmann
2015-04-04 0:14 ` Alexei Starovoitov
[not found] ` <551F2CD4.2080502-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-04-04 6:34 ` Daniel Borkmann [this message]
2015-04-07 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551F85DE.3010804@iogearbox.net \
--to=daniel-fec+5ew28dpmcu3hniyyjq@public$(echo .)gmane.org \
--cc=ast-uqk4Ao+rVK5Wk0Htik3J/w@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=jhs-jkUAjuhPggJWk0Htik3J/w@public$(echo .)gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public$(echo .)gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox