From: Rick Jones <rick.jones2@hp•com>
To: David Miller <davem@davemloft•net>, hannes@stressinduktion•org
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/2] ipv4: ip_tunnel: use net namespace from rtable not socket
Date: Wed, 08 Apr 2015 10:31:06 -0700 [thread overview]
Message-ID: <552565DA.5010606@hp.com> (raw)
In-Reply-To: <20150408.120958.1217271670558706137.davem@davemloft.net>
On 04/08/2015 09:09 AM, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@stressinduktion•org>
> Date: Wed, 8 Apr 2015 17:01:22 +0200
>
>> The socket parameter might legally be NULL, thus sock_net is sometimes
>> causing a NULL pointer dereference. Using net_device pointer in dst_entry
>> is more reliable.
>>
>> Fixes: b6a7719aedd7e5c ("ipv4: hash net ptr into fragmentation bucket selection")
>> Reported-by: Rick Jones <rick.jones2@hp•com>
>> Cc: Rick Jones <rick.jones2@hp•com>
>> Cc: David S. Miller <davem@davemloft•net>
>> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
>
> Applied.
Horses, barn doors, crossed i's and dotted t's but I can report that
with that in place the problem I reported in "VxLAN system wedge in
4.0.0-rc5+ from davem net-next?" no longer happens.
rick
prev parent reply other threads:[~2015-04-08 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 15:01 [PATCH net-next 1/2] ipv4: ip_tunnel: use net namespace from rtable not socket Hannes Frederic Sowa
2015-04-08 15:01 ` [PATCH net-next 2/2] ipv6: call iptunnel_xmit with NULL sock pointer if no tunnel sock is available Hannes Frederic Sowa
2015-04-08 16:10 ` David Miller
2015-04-08 16:09 ` [PATCH net-next 1/2] ipv4: ip_tunnel: use net namespace from rtable not socket David Miller
2015-04-08 17:31 ` Rick Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552565DA.5010606@hp.com \
--to=rick.jones2@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox