From: Zefan Li <lizefan@huawei•com>
To: Tim Niemeyer <tim.niemeyer@corscience•de>
Cc: <stable@vger•kernel.org>,
Jaganath Kanakkassery <jaganath.k@samsung•com>,
Chan-Yeol Park <chanyeol.park@samsung•com>,
Gustavo Padovan <gustavo.padovan@collabora•co.uk>,
Jianguo Wu <wujianguo@huawei•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
Marcel Holtmann <marcel@holtmann•org>,
Gustavo Padovan <gustavo@padovan•org>,
Johan Hedberg <johan.hedberg@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
<linux-bluetooth@vger•kernel.org>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: Re: [3.4 PATCH] Bluetooth: Fix invalid length check in l2cap_information_rsp()
Date: Thu, 9 Apr 2015 09:08:43 +0800 [thread overview]
Message-ID: <5525D11B.3010601@huawei.com> (raw)
In-Reply-To: <1427707657-28545-1-git-send-email-tim.niemeyer@corscience.de>
On 2015/3/30 17:27, Tim Niemeyer wrote:
> first backport commit 6ec88fcb4aa2c33fe2fe2a23c576a7e2581c5c3d changes
> l2cap_move_channel_confirm_rsp and not the l2cap_information_rsp. So
> revert this and fix at the correct position.
>
> commit 3f6fa3d489e127ca5a5b298eabac3ff5dbe0e112 upstream.
>
> The length check is invalid since the length varies with type of
> info response.
>
> This was introduced by the commit cb3b3152b2f5939d67005cff841a1ca748b19888
>
> Because of this, l2cap info rsp is not handled and command reject is sent.
>
>> ACL data: handle 11 flags 0x02 dlen 16
> L2CAP(s): Info rsp: type 2 result 0
> Extended feature mask 0x00b8
> Enhanced Retransmission mode
> Streaming mode
> FCS Option
> Fixed Channels
> < ACL data: handle 11 flags 0x00 dlen 10
> L2CAP(s): Command rej: reason 0
> Command not understood
>
> Cc: stable@vger•kernel.org
> Signed-off-by: Jaganath Kanakkassery <jaganath.k@samsung•com>
> Signed-off-by: Chan-Yeol Park <chanyeol.park@samsung•com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora•co.uk>
> Cc: Jianguo Wu <wujianguo@huawei•com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Signed-off-by: Tim Niemeyer <tim.niemeyer@corscience•de>
> Acked-by: Johan Hedberg <johan.hedberg@intel•com>
> ---
> Patch for 3.4-stable.
>
Queued up for 3.4. Thanks!
prev parent reply other threads:[~2015-04-09 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 9:27 [3.4 PATCH] Bluetooth: Fix invalid length check in l2cap_information_rsp() Tim Niemeyer
2015-04-09 1:08 ` Zefan Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5525D11B.3010601@huawei.com \
--to=lizefan@huawei$(echo .)com \
--cc=chanyeol.park@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gustavo.padovan@collabora$(echo .)co.uk \
--cc=gustavo@padovan$(echo .)org \
--cc=jaganath.k@samsung$(echo .)com \
--cc=johan.hedberg@gmail$(echo .)com \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marcel@holtmann$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tim.niemeyer@corscience$(echo .)de \
--cc=wujianguo@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox