From: Shradha Shah <sshah@solarflare•com>
To: David Miller <davem@davemloft•net>, <eric.dumazet@gmail•com>
Cc: <netdev@vger•kernel.org>, <linux-net-drivers@solarflare•com>
Subject: Re: [PATCH net-next 1/2] sfc: Own header for nic-specific sriov functions, single instance of netdev_ops and sriov removed from Falcon code
Date: Thu, 9 Apr 2015 10:54:01 +0100 [thread overview]
Message-ID: <55264C39.4090503@solarflare.com> (raw)
In-Reply-To: <20150408.162842.1573769781306113806.davem@davemloft.net>
On 08/04/15 21:28, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Wed, 08 Apr 2015 12:57:05 -0700
>
>> On Wed, 2015-04-08 at 12:52 -0700, Eric Dumazet wrote:
>>> On Wed, 2015-04-08 at 15:24 +0100, Shradha Shah wrote:
>>> CC [M] drivers/net/ethernet/sfc/qt202x_phy.o
>>> drivers/net/ethernet/sfc/siena.c:1008:22: error: 'efx_siena_sriov_set_vf_mac' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/siena.c:1009:23: error: 'efx_siena_sriov_set_vf_vlan' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/siena.c:1010:27: error: 'efx_siena_sriov_set_vf_spoofchk' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/siena.c:1011:25: error: 'efx_siena_sriov_get_vf_config' undeclared here (not in a function)
>>> CC [M] drivers/net/ethernet/sfc/mdio_10g.o
>>> make[5]: *** [drivers/net/ethernet/sfc/siena.o] Error 1
>>> make[5]: *** Waiting for unfinished jobs....
>>> drivers/net/ethernet/sfc/ef10.c:3700:22: error: 'efx_ef10_sriov_set_vf_mac' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/ef10.c:3701:23: error: 'efx_ef10_sriov_set_vf_vlan' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/ef10.c:3702:27: error: 'efx_ef10_sriov_set_vf_spoofchk' undeclared here (not in a function)
>>> drivers/net/ethernet/sfc/ef10.c:3703:25: error: 'efx_ef10_sriov_get_vf_config' undeclared here (not in a function)
>>> make[5]: *** [drivers/net/ethernet/sfc/ef10.o] Error 1
>>>
>>
>> Please test your driver with :
>>
>> $ grep PCI_IOV .config
>> # CONFIG_PCI_IOV is not set
>> $ grep SFC_SRIOV .config
>> $
>
> This is really terrible.
I apologize. I will correct this in net_driver.h
>
> siena_sriov.c is only build when CONFIG_SFC_SRIOV is enabled, but it has
> CONFIG_SFC_SRIOV CPP checks all over the file. I don't know what better
> can define a low quality patch submission...
siena_sriov.c is not a new file. I think a cleanup patch for cleaning up all
the CONFIG_SFC_SRIOV CPP checks is required before I post any new patches.
Will correct and send out a v2.
>
> I tried to fix this up, but it's way too broken for a quick cure,
> therefore I'm reverting everything.
>
--
Many Thanks,
Regards,
Shradha Shah
next prev parent reply other threads:[~2015-04-09 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 14:22 [PATCH net-next 0/2] sfc: Nic specific sriov functions, netdev_ops and sriov_configure Shradha Shah
2015-04-08 14:24 ` [PATCH net-next 1/2] sfc: Own header for nic-specific sriov functions, single instance of netdev_ops and sriov removed from Falcon code Shradha Shah
2015-04-08 19:52 ` Eric Dumazet
2015-04-08 19:57 ` Eric Dumazet
2015-04-08 20:28 ` David Miller
2015-04-09 9:54 ` Shradha Shah [this message]
2015-04-09 8:33 ` Shradha Shah
2015-04-08 14:25 ` [PATCH net-next 2/2] sfc: Enable VF's via a write to the sysfs file sriov_numvfs Shradha Shah
2015-04-08 16:22 ` [PATCH net-next 0/2] sfc: Nic specific sriov functions, netdev_ops and sriov_configure David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55264C39.4090503@solarflare.com \
--to=sshah@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox