From: Florian Fainelli <f.fainelli@gmail•com>
To: Mason <slash.tmp@free•fr>, Daniel Mack <daniel@zonque•org>,
netdev@vger•kernel.org
Cc: Mugunthan <mugunthanvnm@ti•com>,
"David S. Miller" <davem@davemloft•net>,
Matus Ujhelyi <ujhelyi.m@gmail•com>
Subject: Re: Atheros 8035 PHY only works when at803x_config_init() is commented out
Date: Thu, 09 Apr 2015 10:25:28 -0700 [thread overview]
Message-ID: <5526B608.2080504@gmail.com> (raw)
In-Reply-To: <5526993F.1010304@free.fr>
On 09/04/15 08:22, Mason wrote:
> Mason wrote:
>
>> Daniel Mack wrote:
>>
>>> My suggestion is to dump the entire register set when
>>> at803x_config_init() is entered and again when it's left. Then try to
>>> find the differences and see if you can bring the PHY into the needed
>>> mode through the existing configuration hooks in the kernel.
>>
>> [ 0.685330] IDX= 1 796d != 7949
>> [ 0.688490] IDX= 5 c1e1 != 0000
>> [ 0.691647] IDX= 6 000f != 0004
>> [ 0.694803] IDX=10 3800 != 0000
>> [ 0.697960] IDX=17 bc10 != 0012
>> [ 0.701115] IDX=19 7400 != 0000
>> [ 0.704271] IDX=27 060e != 0600
>>
>> Hmmm, didn't expect so many differences. I'll have to take a closer look.
>
> For the record, I dumped the PHY registers
> A) upon entering phy_init_hw
> B) before leaving phy_init_hw (thus right after at803x_config_init)
>
> IDX 1: b2 LINK STATUS, b5 AUTO-NEGOTIATION COMPLETE
> => Difference in status bits, seems reasonable
>
> IDX 5: Link partner ability (base page)
> => seems reasonable (no partner yet?)
>
> IDX 6: Auto-Negotiation Expansion
> => seems reasonable (no partner yet?)
>
> IDX 10: 1000 BASE-T Status (HW reset = SW reset = 0)
> (ALSO: Contents of this register clear after a read operation has
> occurred.)
> => Looks like my own read cleared it
>
> IDX 17: PHY-Specific Status
> b1 = "POLARITY (real time)"?
> => Difference in status bits, seems reasonable? (
>
> IDX 19: Interrupt Status
> => Looks like some interrupt requests might have been discarded?
>
> IDX 27: This register is undocumented
>
> Nothing looks suspicious, except maybe the Interrupt Status?
>
> Is speed auto-negotiation supposed to be complete when phy_init_hw exits?
There is no such guarantee, and the PHY state machine is started later,
which will take care of auto-neg and other things.
--
Florian
next prev parent reply other threads:[~2015-04-09 17:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 16:28 Atheros 8035 PHY only works when at803x_config_init() is commented out Mason
2015-04-08 17:29 ` Florian Fainelli
2015-04-08 21:37 ` Mason
2015-04-09 11:44 ` Mason
2015-04-09 13:15 ` Mason
2015-04-09 13:36 ` Daniel Mack
2015-04-09 14:38 ` Mason
2015-04-09 15:22 ` Mason
2015-04-09 15:32 ` Daniel Mack
2015-04-09 15:58 ` Mason
2015-04-09 17:25 ` Florian Fainelli [this message]
2015-04-09 18:52 ` Mason
2015-04-09 19:00 ` Florian Fainelli
2015-04-09 19:30 ` Mason
2015-04-09 20:26 ` Florian Fainelli
2015-04-09 22:10 ` Mason
2015-04-09 22:30 ` Florian Fainelli
2015-04-09 22:31 ` Fabio Estevam
2015-04-10 10:27 ` Fabio Estevam
2015-04-10 15:04 ` Mason
2015-04-10 9:33 ` Daniel Mack
2015-04-10 10:01 ` Mason
2015-04-10 10:21 ` Daniel Mack
2015-04-09 19:05 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5526B608.2080504@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=slash.tmp@free$(echo .)fr \
--cc=ujhelyi.m@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox