Subject: Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

From: Florian Fainelli <[email-masked]>
Date: Mon, 13 Apr 2015 10:49:04 -0700

On 12/04/15 23:17, [email-masked] wrote:
> From: Scott Feldman <[email-masked]>
> 
> VLAN obj has flags (PVID and untagged) as well as start and end vid ranges.
> The swdev driver can optimize programing the device using the ranges.
> 
> Signed-off-by: Scott Feldman <[email-masked]>
> ---
>  include/net/switchdev.h |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index f5f7733..d3cc8eb 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -45,12 +45,20 @@ struct fib_info;
>  
>  enum swdev_obj_id {
>  	SWDEV_OBJ_UNDEFINED,
> +	SWDEV_OBJ_PORT_VLAN,
>  };
>  
>  struct swdev_obj {
>  	enum swdev_obj_id id;
>  	enum swdev_trans trans;
>  	u32 flags;
> +	union {
> +		struct swdev_obj_vlan {			/* PORT_VLAN */
> +			u16 flags;

Should not we enforce some sort of definition of how we plan on using
the "flags" member here?, if not, we might just as well remove it from
this patch set until we actually use it?
-- 
Florian