From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: netdev@vger•kernel.org,
"Eric W. Biederman" <ebiederm@xmission•com>,
James Morris <jmorris@redhat•com>
Subject: Re: ip_tunnel: Remove gratuitous skb scrubbing
Date: Wed, 15 Apr 2015 17:41:26 +0200 [thread overview]
Message-ID: <552E86A6.9000101@6wind.com> (raw)
In-Reply-To: <20150415135739.GA5534@gondor.apana.org.au>
Le 15/04/2015 15:57, Herbert Xu a écrit :
> On Wed, Apr 15, 2015 at 06:22:29PM +0800, Herbert Xu wrote:
[snip]
> Subject: skbuff: Do not scrub skb mark within the same name space
>
> The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 ("tunnels:
Maybe add a Fixes tag?
Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path")
> harmonize cleanup done on skb on rx path") broke anyone trying to
> use netfilter marking across IPv4 tunnels. While most of the
> fields that are cleared by skb_scrub_packet don't matter, the
> netfilter mark must be preserved.
>
> This patch rearranges skb_scurb_packet to preserve the mark field.
nit: s/scurb/scrub
Else it's fine for me.
next prev parent reply other threads:[~2015-04-15 15:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 10:01 ip_tunnel: Remove gratuitous skb scrubbing Herbert Xu
2015-04-15 10:13 ` Herbert Xu
2015-04-15 10:20 ` Nicolas Dichtel
2015-04-15 10:22 ` Herbert Xu
2015-04-15 10:28 ` Nicolas Dichtel
2015-04-15 10:32 ` Herbert Xu
2015-04-15 13:57 ` Herbert Xu
2015-04-15 15:41 ` Nicolas Dichtel [this message]
2015-04-16 1:03 ` [v3] skbuff: Do not scrub skb mark within the same name space Herbert Xu
2015-04-16 7:02 ` James Morris
2015-04-16 7:35 ` Nicolas Dichtel
2015-04-16 7:59 ` Herbert Xu
2015-04-16 8:12 ` Revert "net: Reset secmark when scrubbing packet" Herbert Xu
2015-04-16 8:32 ` Thomas Graf
2015-04-16 18:21 ` David Miller
2015-04-16 8:33 ` [v3] skbuff: Do not scrub skb mark within the same name space Thomas Graf
2015-04-16 18:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E86A6.9000101@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jmorris@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox