Subject: Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

From: Guenter Roeck <[email-masked]>
Date: Thu, 16 Apr 2015 05:51:46 -0700

On 04/16/2015 05:37 AM, Andrew Lunn wrote:
> On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote:
>> Return correct error code if _mv88e6xxx_reg_read returns an error.
>>
>> Fixes: facd95b2e0ec0 ("net: dsa: mv88e6xxx: Add Hardware bridging support")
>> Signed-off-by: Guenter Roeck <[email-masked]>
>
> Hi Guenter
>
> Good catch. I'm surprised there is no compiler warning, possibly used
> before set.
>
There was, actually. No idea how I missed that. Fengguang's build bots caught it.

> Reviewed-by: Andrew Lunn <[email-masked]>
>
Thanks!

Guenter