From: Daniel Borkmann <daniel@iogearbox•net>
To: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>
Cc: netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH net] inet_diag: fix access to tcp cc information
Date: Fri, 17 Apr 2015 10:31:38 +0200 [thread overview]
Message-ID: <5530C4EA.9020205@iogearbox.net> (raw)
In-Reply-To: <1429233035.7346.240.camel@edumazet-glaptop2.roam.corp.google.com>
On 04/17/2015 03:10 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> Two different problems are fixed here :
>
> 1) inet_sk_diag_fill() might be called without socket lock held.
> icsk->icsk_ca_ops can change under us and module be unloaded.
> -> Access to freed memory.
> Fix this using rcu_read_lock() to prevent module unload.
>
> 2) Some TCP Congestion Control modules provide information
> but again this is not safe against icsk->icsk_ca_ops
> change and nla_put() errors were ignored. Some sockets
> could not get the additional info if skb was almost full.
>
> Fix this by returning a status from get_info() handlers and
> using rcu protection as well.
>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
Thanks Eric!
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
next prev parent reply other threads:[~2015-04-17 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 1:10 [PATCH net] inet_diag: fix access to tcp cc information Eric Dumazet
2015-04-17 8:31 ` Daniel Borkmann [this message]
2015-04-17 17:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5530C4EA.9020205@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox