Subject: Re: [PATCH net-next] ip: Add color output option

From: Daniel Borkmann <[email-masked]>
Date: Fri, 17 Apr 2015 19:26:54 +0200

On 04/17/2015 06:44 PM, Alexei Starovoitov wrote:
> On Fri, Apr 17, 2015 at 04:02:02PM +0300, Mathias Nyman wrote:
>> It is hard to quickly find what you are looking for in the output of the ip
>> command. Color helps.
>>
>> This patch adds a '-c' flag to highlight these with individual colors:
>>    - interface name
>>    - ip addresse
>>    - mac addresse
>>    - up/down state
>
> idea looks good, but the patch doesn't apply at all, since it's
> whitespace damaged. Also there is no SOB.

You also might want to move the library bits into lib/ so that
not only ip but also other tools could use it in future. So -c
is neither taken in ip nor in tc or ss, that's good. ;)