From: Or Gerlitz <ogerlitz@mellanox•com>
To: <amirv@mellanox•com>
Cc: David Miller <davem@davemloft•net>, <netdev@vger•kernel.org>,
<yevgenyp@mellanox•com>, <saeedm@mellanox•com>,
<achiad@mellanox•com>, <idos@mellanox•com>, <talal@mellanox•com>
Subject: Re: [PATCH net-next V2 12/12] net/mlx5: Ethernet driver
Date: Tue, 21 Apr 2015 16:30:40 +0300 [thread overview]
Message-ID: <55365100.4060208@mellanox.com> (raw)
In-Reply-To: <20150414.145113.192331451516214119.davem@davemloft.net>
On 4/14/2015 9:51 PM, David Miller wrote:
> From: Amir Vadai <amirv@mellanox•com>
> Date: Tue, 14 Apr 2015 11:20:35 +0300
>
>> Signed-off-by: Amir Vadai <amirv@mellanox•com>
> What does "Ethernet driver" mean?
>
> Are you adding a new ethernet driver? If so, what is it for and how
> does it interact with the existing mlx5 driver?
>
> It looks to me like you are adding a lot of code and objects to the
> existing mlx5 module. An incredible amount, in fact. This seems very
> suboptimal especially for users of the existing mlx5 chips.
Hi Dave,
To clarify things a bit, the mlx5 driver serves two NICs families:
ConnectIB (device IDs 0x1011/12) and ConnectX4 (device IDs 1013-1016).
ConnectIB HW is IB only, ConnextX4 is IB and Ethernet.
This submission enhances the driver to support Ethernet for the
ConnectX4 family.
In a similar manner to the mlx4 driver stacking, mlx5 has has IB driver
and core driver. Per your comments, in V3, the Ethernet functionality
would be added per dedicated config directive, such that if someone
wants only the IB driver to be functional, the Ethernet netdev code and
such doesn't get built.
> You haven't discussed this, what design decisions made you decide in the end to do it this way, etc.
>
> You absolutely have to say something other than "Ethernet driver"
> in this commit message, I expect several paragraphs of details
> and the hows and whys of the change as it is a non-trivial amount
> of code being added here.
Understood, will add more text to the cover letter, change-logs, etc.
> I still consider this patch series not ready yet, and the merge
> window is open thus closing the net-next tree.
>
> You will therefore need to wait until the net-next tree opens
> again before submitting this series again.
Sure, thanks for the review feedback provided so far.
BTW Sorry for the late reply, just realized today there has been no
response on your comments.
Or.
prev parent reply other threads:[~2015-04-21 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 8:20 [PATCH net-next V2 00/12] net/mlx5: ConnectX-4 100G Ethernet driver Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 01/12] net/mlx5_core,mlx5_ib: Do not use vmap() on coherent memory Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 02/12] net/mlx5_core: Set irq affinity hints Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 03/12] net/mlx5_core: Add EQ renaming mechanism Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 04/12] net/mlx5_core: HW data structs/types definitions preparation for mlx5 ehternet driver Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 05/12] net/mlx5_core/ib: New device capabilities handling Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 06/12] net/mlx5_core: Implement get and set functions of ptys register fields Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 07/12] net/mlx5_core: Implement get/set port status Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 08/12] net/mlx5_core: Modify CQ moderation parameters Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 09/12] net/mlx5_core: Set/Query port MTU commands Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 10/12] net/mlx5: Ethernet Datapath files Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 11/12] net/mlx5: Ethernet resources handling Amir Vadai
2015-04-14 8:20 ` [PATCH net-next V2 12/12] net/mlx5: Ethernet driver Amir Vadai
2015-04-14 18:51 ` David Miller
2015-04-21 13:30 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55365100.4060208@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=achiad@mellanox$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idos@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
--cc=talal@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox