Subject: Re: [PATCH net-next] be2net: log link status

From: Ivan Vecera <[email-masked]>
Date: Wed, 22 Apr 2015 15:22:50 +0200

On 04/22/2015 03:10 PM, Joe Perches wrote:
> On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote:
>> The driver unlike other drivers does not log link state changes.
> []
>> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> []
>> @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
>>   		netif_carrier_on(netdev);
>>   	else
>>   		netif_carrier_off(netdev);
>> +
>> +	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
>>   }
>
> If this is valuable, it's also valuable to emit the
> link speed/duplex states like most other drivers.
>
Duplex state is not much valuable as for be2net link-up means 
full-duplex and link-down means unknown-duplex.
But link speed could be valuable. Will send v2.

Ivan