From: Daniel Borkmann <daniel@iogearbox•net>
To: Johannes Berg <johannes@sipsolutions•net>,
David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, kaber@trash•net, tgraf@suug•ch,
herbert@gondor•apana.org.au
Subject: Re: [PATCH] rhashtable: don't attempt to grow when at max_size
Date: Thu, 23 Apr 2015 18:16:08 +0200 [thread overview]
Message-ID: <55391AC8.3020901@iogearbox.net> (raw)
In-Reply-To: <1429805376.1859.5.camel@sipsolutions.net>
On 04/23/2015 06:09 PM, Johannes Berg wrote:
> On Thu, 2015-04-23 at 11:59 -0400, David Miller wrote:
>
>>> This fixes the "lost insertion" issue and consequently allows my
>>> code to display its error (and verify my fix for it.)
>
>> It looks fine to me, but I'll let Herbert and Thomas review this.
>
> Oh, sorry, didn't know Herbert was also involved with this.
Would be good to add Fixes tags, commit in question seems to be:
ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
> Anyway, that's a good idea. I really went for "this looks obvious" and
> patched it, and it started working for me thereafter. I don't know
> anything about side effects here.
next prev parent reply other threads:[~2015-04-23 16:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 14:38 [PATCH] rhashtable: don't attempt to grow when at max_size Johannes Berg
2015-04-23 15:59 ` David Miller
2015-04-23 16:09 ` Johannes Berg
2015-04-23 16:16 ` Daniel Borkmann [this message]
2015-04-24 0:57 ` rhashtable: Add cap on number of elements in hash table Herbert Xu
2015-04-24 7:01 ` Johannes Berg
2015-04-24 8:04 ` Herbert Xu
2015-04-24 8:06 ` Thomas Graf
2015-04-24 8:12 ` Herbert Xu
2015-04-24 8:15 ` Thomas Graf
2015-04-24 8:22 ` Herbert Xu
2015-04-24 15:38 ` David Miller
2015-05-13 8:06 ` Herbert Xu
2015-05-15 2:22 ` David Miller
2015-05-15 3:06 ` Herbert Xu
2015-05-15 3:46 ` David Miller
2015-05-15 6:30 ` Herbert Xu
2015-05-16 22:09 ` David Miller
2015-05-17 1:38 ` Herbert Xu
2015-05-18 20:12 ` David Miller
2015-05-18 22:35 ` Herbert Xu
2015-05-19 10:25 ` David Laight
2015-05-15 3:30 ` [v2 PATCH] " Herbert Xu
2015-05-16 22:08 ` David Miller
2015-04-23 20:46 ` [PATCH] rhashtable: don't attempt to grow when at max_size Thomas Graf
2015-04-23 20:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55391AC8.3020901@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox