From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Subject: Re: [Patch net] net_sched: fix a use-after-free in tc_ctl_tfilter()
Date: Wed, 06 May 2015 17:24:53 -0400 [thread overview]
Message-ID: <554A86A5.2030804@mojatatu.com> (raw)
In-Reply-To: <1430864522-15691-1-git-send-email-xiyou.wangcong@gmail.com>
On 05/05/15 18:22, Cong Wang wrote:
> When tcf_destroy() returns true, tp could be already destroyed,
> we should not use tp->next after that.
>
> For long term, we probably should move tp list to list_head.
>
> Fixes: 1e052be69d04 ("net_sched: destroy proto tp when all filters are gone")
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
cheers,
jamal
next prev parent reply other threads:[~2015-05-06 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 22:22 [Patch net] net_sched: fix a use-after-free in tc_ctl_tfilter() Cong Wang
2015-05-06 21:24 ` Jamal Hadi Salim [this message]
2015-05-09 20:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A86A5.2030804@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox