Subject: Re: [PATCH 2/6] net: Add a struct net parameter to sock_create_kern

From: Nicolas Dichtel <[email-masked]>
Date: Tue, 12 May 2015 14:28:53 +0200

Le 12/05/2015 13:48, David Laight a écrit :
> From: Eric W. Biederman
>> Sent: 12 May 2015 09:55
>>
>> On May 12, 2015 3:24:11 AM CDT, David Laight <[email-masked]> wrote:
> ...
>>> Wouldn't it involve far less churn to add a new function that uses a
>>> non-default namespace?
>>
>> The goal is comprehensible and maintainable kernel code.
>>
>> Which network namespace your socket is in, is an important property and something you probably care
>> about if you are creating kernel sockets.
>
> That rather depends on whether you've anywhere to get a namespace from.
> eg something like ceph/messenger.c
sk_net(con->sock->sk)?

This parameter is essential, hiding it will just hides bugs.
Having this parameter forces the developer to ask himself what is the best
value.