Subject: Re: [PATCH net-next v1 4/7] amd-xgbe: Move the PHY support into amd-xgbe

From: Florian Fainelli <[email-masked]>
Date: Tue, 12 May 2015 15:19:55 -0700

On 12/05/15 12:22, Tom Lendacky wrote:
> The AMD XGBE device is intended to work with a specific integrated PHY
> and that PHY is not meant to be a standalone PHY for use by other
> devices. As such this patch removes the phylib driver and implements
> the PHY support in the amd-xgbe driver (the majority of the logic from
> the phylib driver is moved into the amd-xgbe driver).

Did not you submit a similar patch a while ago and David asked to keep
the PHY driver separate? Even though the internal PHY driver might not
be reusable on another platform, having your Ethernet driver implement a
PHY library driver seems like a potential layering issue.
-- 
Florian