Subject: Re: [PATCH net-next v2] net: core: set and refine qdisc pkt len before tc_classify

From: Alexei Starovoitov <[email-masked]>
Date: Wed, 13 May 2015 14:07:00 -0700

On 5/13/15 1:50 PM, Daniel Borkmann wrote:
> From: Florian Westphal <[email-masked]>
>
> Commit d2788d34885d4ce5ba ("net: sched: further simplify handle_ing")
> removed the call to qdisc_enqueue_root(). However, after this removal
> we no longer set qdisc pkt length, which this patch fixes. We make use
> of qdisc_pkt_len_init() from 1def9238d4aa ("net_sched: more precise
> pkt_len computation"), which was suggested as the current approach so
> far does not take into account when GRO builds up GSO packets.
>
> Fixes: d2788d34885d ("net: sched: further simplify handle_ing")
> Suggested-by: Jamal Hadi Salim <[email-masked]>
> Signed-off-by: Florian Westphal <[email-masked]>
> Signed-off-by: Daniel Borkmann <[email-masked]>
> ---

Looks good as quick fix for now. Long term I still want to try to reuse
stats from underlying netdev ;)
For TX we don't have this option and have to do qdisc_pkt_len_init(),
but for RX we should be able to do something smarter.

Acked-by: Alexei Starovoitov <[email-masked]>