Subject: Re: [PATCH net-next v2] rocker: fix a neigh entry leak issue

From: Ying Xue <[email-masked]>
Date: Fri, 15 May 2015 10:30:18 +0800

On 05/15/2015 10:26 AM, David Miller wrote:
> From: Ying Xue <[email-masked]>
> Date: Fri, 15 May 2015 09:33:25 +0800
> 
>> Once we get a neighbour through looking up arp cache or creating a
>> new one in rocker_port_ipv4_resolve(), the neighbour's refcount is
>> already taken. But as we don't put the refcount again after it's
>> used, this makes the neighbour entry leaked.
>>
>> Suggested-by: Eric Dumazet <[email-masked]>
>> Acked-by: Jiri Pirko <[email-masked]>
>> Signed-off-by: Ying Xue <[email-masked]>
>> ---
>> v2:
>>   Add the checking of return value of neigh_create() with IS_ERR()
>>   to avoid another crash, which is suggested by Eric Dumazet.
> 
> Doesn't this leak exist in the 'net' tree?
> 
> If so, why are you targetting such a bug fix for 'net-next'?
> 
> 

Sorry, I am used to develop in net-next tree. Please wait a moment, I will check
whether the issue also exists in net tree.

Regards,
Ying