From: Florian Fainelli <f.fainelli@gmail•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, linux@roeck-us•net, peppe.cavallaro@st•com
Subject: Re: [PATCH net] net: phy: Allow EEE for all RGMII variants
Date: Fri, 15 May 2015 19:01:40 -0700 [thread overview]
Message-ID: <5556A504.4080804@gmail.com> (raw)
In-Reply-To: <20150515.212209.277936395883084581.davem@davemloft.net>
Le 05/15/15 18:22, David Miller a écrit :
> From: Florian Fainelli <f.fainelli@gmail•com>
> Date: Fri, 15 May 2015 16:30:41 -0700
>
>> RGMII interfaces come in multiple flavors: RGMII with transmit or
>> receive internal delay, no delays at all, or delays in both direction.
>>
>> This change extends the initial check for PHY_INTERFACE_MODE_RGMII to
>> cover all of these variants since EEE should be allowed for any of these
>> modes, since it is a property of the RGMII, hence Gigabit PHY capability
>> more than the RGMII electrical interface and its delays.
>>
>> Fixes: a59a4d192166 ("phy: add the EEE support and the way to access to the MMD registers")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
>
> This is not the first time I've seen this bug.
>
> A helper like phydev_is_rgmii() is probably long overdue.
Sounds very reasonable, I will cook something which does that, thanks!
>
>> David this change dates back to 3.6, however the comment update will depend on
>> a9f6309585cbefa4a7f08c9017ca482c3222323a ("net: phy: allow phy_init_eee() to
>> work with internal PHYs") to be included, which is only 3.18, nobody but me
>> really complained about that so I guess 3.18+ is reasonable.
>
> Ok, applied and queued up for -stable, thanks.
>
--
Florian
prev parent reply other threads:[~2015-05-16 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 23:30 [PATCH net] net: phy: Allow EEE for all RGMII variants Florian Fainelli
2015-05-16 1:22 ` David Miller
2015-05-16 2:01 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5556A504.4080804@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox