Subject: Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue

From: Nicolas Dichtel <[email-masked]>
Date: Wed, 20 May 2015 10:12:28 +0200

Le 18/05/2015 22:59, David Miller a écrit :
> From: "John W. Linville" <[email-masked]>
> Date: Mon, 18 May 2015 13:51:24 -0400
>
>> By inspection, this appears to be a typo.  The gating comparison
>> involves vxlan->dev rather than dev.  In fact, dev is the iterator in
>> the preceding loop above but it is actually constant in the 2nd loop.
>>
>> Use of dev seems to be a bad cut-n-paste from the prior call to
>> unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
>> what is actually being checked.
>>
>> Signed-off-by: John W. Linville <[email-masked]>
>
> Indeed, your fix looks correct to me.
>
> Applied, thanks John.
>
I was off the last couple of days. But I agree with that patch.
FWIW:
Fixes: f01ec1c017de ("vxlan: add x-netns support")