From: Lino Sanfilippo <LinoSanfilippo@gmx•de>
To: Gabriel Krisman Bertazi <krisman@linux•vnet.ibm.com>,
Yuval Mintz <Yuval.Mintz@qlogic•com>
Cc: David Miller <davem@davemloft•net>,
Ariel Elior <Ariel.Elior@qlogic•com>,
netdev <netdev@vger•kernel.org>,
"cascardo@cascardo•eti.br" <cascardo@cascardo•eti.br>,
"brking@linux•vnet.ibm.com" <brking@linux•vnet.ibm.com>
Subject: Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element
Date: Sat, 23 May 2015 13:14:35 +0200 [thread overview]
Message-ID: <5560611B.6060500@gmx.de> (raw)
In-Reply-To: <87wq02t6ce.fsf_-_@dhcp-9-18-235-171.br.ibm.com>
On 21.05.2015 15:20, Gabriel Krisman Bertazi wrote:
> Yuval Mintz <Yuval.Mintz@qlogic•com> writes:
>
>> Regardless, I'll give it a more thorough review tomorrow.
>> [If those are all the "problems" we'll find with it, I don't think we'll
>> need to re-spin this once more; that is, unless Dave insists]
>
> As a follow up, here is a new version that fixes the style issues that Yuval
> pointed out. Are there any other concerns regarding this one?
>
Hi Gabriel,
the patch looks good concerning this issue in a former version:
http://marc.info/?l=linux-netdev&m=142991786419997&w=2
And (at least to me) it also looks good on the whole. You can
add Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx•de>.
Regards,
Lino
next prev parent reply other threads:[~2015-05-23 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 20:45 [PATCH v2] bnx2x: Alloc 4k fragment for each rx ring buffer element Gabriel Krisman Bertazi
2015-04-24 23:24 ` Lino Sanfilippo
2015-04-29 13:30 ` Gabriel Krisman Bertazi
2015-04-30 11:25 ` Yuval Mintz
2015-04-30 20:05 ` David Miller
2015-05-04 19:32 ` [PATCH v3] " Gabriel Krisman Bertazi
2015-05-04 19:58 ` Yuval Mintz
2015-05-15 20:43 ` Gabriel Krisman Bertazi
2015-05-17 7:14 ` Yuval Mintz
2015-05-21 13:20 ` [PATCH v4] " Gabriel Krisman Bertazi
2015-05-23 10:04 ` Yuval Mintz
2015-05-23 11:14 ` Lino Sanfilippo [this message]
2015-05-27 8:59 ` Michal Schmidt
2015-05-27 16:51 ` [PATCH] " Gabriel Krisman Bertazi
2015-06-01 22:57 ` David Miller
2015-05-28 7:24 ` [PATCH v4] " Yuval Mintz
2015-05-28 13:26 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560611B.6060500@gmx.de \
--to=linosanfilippo@gmx$(echo .)de \
--cc=Ariel.Elior@qlogic$(echo .)com \
--cc=Yuval.Mintz@qlogic$(echo .)com \
--cc=brking@linux$(echo .)vnet.ibm.com \
--cc=cascardo@cascardo$(echo .)eti.br \
--cc=davem@davemloft$(echo .)net \
--cc=krisman@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox