From: Edward Cree <ecree@solarflare•com>
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <linux-net-drivers@solarflare•com>
Subject: [PATCH net-next v4 0/3] sfc: add MCDI tracing
Date: Wed, 27 May 2015 13:12:31 +0100 [thread overview]
Message-ID: <5565B4AF.50603@solarflare.com> (raw)
This patchset adds support for logging MCDI (Management-Controller-to-
Driver Interface) interactions between the sfc driver and a bound device,
to aid in debugging.
Solarflare has a tool to decode the resulting traces and will look to
open-source this if there is any external interest, but the protocol is
already detailed in drivers/net/ethernet/sfc/mcdi_pcol.h.
The logging buffer we allocate per MCDI context is a work area for
constructing each individual message before logging it with netif_info.
The reason the buffer is long-lived is simply to avoid the overhead of
allocating and freeing it every MCDI call, since MCDIs are already known
to be serialised for other reasons.
--
v4: remove patch #4, which has already been applied via sshah
v3: add some explanations to cover letter and patch #4
v2: avoid long lines in cover letter; fix multiline comment style
Edward Cree (3):
sfc: add tracing of MCDI commands
sfc: add sysfs entry to control MCDI tracing
sfc: add module parameter to enable MCDI logging on new functions
drivers/net/ethernet/sfc/Kconfig | 9 ++++
drivers/net/ethernet/sfc/ef10.c | 3 ++
drivers/net/ethernet/sfc/efx.c | 49 ++++++++++++++++---
drivers/net/ethernet/sfc/mcdi.c | 100 +++++++++++++++++++++++++++++++++++++--
drivers/net/ethernet/sfc/mcdi.h | 6 +++
5 files changed, 156 insertions(+), 11 deletions(-)
next reply other threads:[~2015-05-27 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 12:12 Edward Cree [this message]
2015-05-27 12:13 ` [PATCH net-next 1/3] sfc: add tracing of MCDI commands Edward Cree
2015-05-27 12:14 ` [PATCH net-next 2/3] sfc: add sysfs entry to control MCDI tracing Edward Cree
2015-05-27 12:14 ` [PATCH net-next 3/3] sfc: add module parameter to enable MCDI logging on new functions Edward Cree
2015-05-27 17:55 ` [PATCH net-next v4 0/3] sfc: add MCDI tracing David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565B4AF.50603@solarflare.com \
--to=ecree@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox