From: Robert Shearman <rshearma@brocade•com>
To: Roopa Prabhu <roopa@cumulusnetworks•com>, <ebiederm@xmission•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>,
<vivek@cumulusnetworks•com>
Subject: Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope
Date: Wed, 27 May 2015 20:46:31 +0100 [thread overview]
Message-ID: <55661F17.5050504@brocade.com> (raw)
In-Reply-To: <1432751825-40804-3-git-send-email-roopa@cumulusnetworks.com>
On 27/05/15 19:37, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>
> Ignore scope for route del messages
>
> Signed-off-by: Vivek Venkataraman <vivek@cumulusnetworks•com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
Reviewed-by: Robert Shearman <rshearma@brocade•com>
> ---
> net/mpls/af_mpls.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
> index 7b3f732..f4eb0dd 100644
> --- a/net/mpls/af_mpls.c
> +++ b/net/mpls/af_mpls.c
> @@ -693,8 +693,10 @@ static int rtm_to_route_config(struct sk_buff *skb, struct nlmsghdr *nlh,
> * (or source specific address in the case of multicast)
> * all addresses have universal scope.
> */
> - if (rtm->rtm_scope != RT_SCOPE_UNIVERSE)
> - goto errout;
> + if (nlh->nlmsg_type != RTM_DELROUTE &&
> + rtm->rtm_scope != RT_SCOPE_UNIVERSE)
> + goto errout;
> +
> if (rtm->rtm_type != RTN_UNICAST)
> goto errout;
> if (rtm->rtm_flags != 0)
>
next prev parent reply other threads:[~2015-05-27 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 18:37 [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope Roopa Prabhu
2015-05-27 19:46 ` Robert Shearman [this message]
2015-06-01 22:58 ` David Miller
2015-06-02 15:35 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55661F17.5050504@brocade.com \
--to=rshearma@brocade$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=vivek@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox