Subject: Re: [PATCH] net: qlcnic: clean up sysfs error codes

From: Vladimir Zapolskiy <[email-masked]>
Date: Fri, 29 May 2015 04:13:46 +0300

Hello David,

On 29.05.2015 02:28, David Miller wrote:
> From: Vladimir Zapolskiy <[email-masked]>
> Date: Tue, 26 May 2015 03:49:45 +0300
> 
>> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL
>> and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the
>> latter error code is arguable, but it is already used in the driver,
>> so let it be here as well.
>>
>> Also remove always false (!buf) check on read(), the driver should
>> not care if userspace gets its EFAULT or not.
>>
>> Signed-off-by: Vladimir Zapolskiy <[email-masked]>
> 
> Qlogic folks, I'm waiting for your promised feedback.
> 

Rajesh reviewed and acked the change, thank you.

http://www.spinics.net/lists/netdev/msg331073.html

--
With best wishes,
Vladimir