From: Daniel Borkmann <daniel@iogearbox•net>
To: Eric Dumazet <eric.dumazet@gmail•com>, Vadim Kochan <vadim4j@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH iproute2] ss: Fix allocation of cong control alg name
Date: Fri, 29 May 2015 13:11:36 +0200 [thread overview]
Message-ID: <55684968.9070206@iogearbox.net> (raw)
In-Reply-To: <1432897445.7456.76.camel@edumazet-glaptop2.roam.corp.google.com>
On 05/29/2015 01:04 PM, Eric Dumazet wrote:
...
> I doubt TCP_CA_NAME_MAX will ever change in the kernel : 16 bytes.
>
> Its typically "cubic" and less than 8 bytes.
>
> Using 8 bytes to point to a malloc(8) is a waste.
>
> Please remove the memory allocation, or store the pointer, since
> tcp_show_info() does the malloc()/free() before return.
+1, much better
next prev parent reply other threads:[~2015-05-29 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 10:30 [PATCH iproute2] ss: Fix allocation of cong control alg name Vadim Kochan
2015-05-29 11:04 ` Eric Dumazet
2015-05-29 11:11 ` Daniel Borkmann [this message]
2015-05-29 12:53 ` Vadim Kochan
2015-05-29 15:15 ` Eric Dumazet
2015-05-29 11:09 ` Daniel Borkmann
2015-05-29 16:17 ` Guzman Mosqueda, Jose R
2015-05-29 16:48 ` Daniel Borkmann
2015-06-25 3:31 ` Stephen Hemminger
2015-06-25 7:12 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55684968.9070206@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vadim4j@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox