From: Guenter Roeck <linux@roeck-us•net>
To: Or Gerlitz <gerlitz.or@gmail•com>,
Vivien Didelot <vivien.didelot@savoirfairelinux•com>
Cc: netdev <netdev@vger•kernel.org>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Jérome Oufella" <jerome.oufella@savoirfairelinux•com>,
"Chris Healy" <cphealy@gmail•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Scott Feldman" <sfeldma@gmail•com>
Subject: Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo
Date: Fri, 29 May 2015 15:15:23 -0700 [thread overview]
Message-ID: <5568E4FB.6060309@roeck-us.net> (raw)
In-Reply-To: <CAJ3xEMhAusqPj9m2a-wx7FDC2rE+WUk3UobE3+nS8qRV8bWTGg@mail.gmail.com>
On 05/29/2015 08:51 AM, Or Gerlitz wrote:
> On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot
> <vivien.didelot@savoirfairelinux•com> wrote:
>> Hi,
>>
>> ----- On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz.or@gmail•com wrote:
>>
>>> On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot
>>> <vivien.didelot@savoirfairelinux•com> wrote:
>>>> @@ -854,7 +922,9 @@ int dsa_slave_create(struct dsa_switch *ds, struct device
>>>> *parent,
>>>> if (slave_dev == NULL)
>>>> return -ENOMEM;
>>>>
>>>> - slave_dev->features = master->vlan_features;
>>>> + slave_dev->features = master->vlan_features |
>>>> + NETIF_F_VLAN_FEATURES |
>>>> + NETIF_F_HW_SWITCH_OFFLOAD;
>>>
>>> wait... didn't commit 7889cbee8357aaed85898d028829dfb4f75bae2c remove
>>> NETIF_F_HW_SWITCH_OFFLOAD?
>>
>> Indeed, note that this RFC is based on v4.1-rc3. This will become unneeded I guess.
>
>
> You should rebase networking patches proposed for the next kernel
> against the net-next tree.
>
>> BTW, given the commit message, I didn't really understand why?
>
> M2, I thought it was unsuccessful commit message and made a comment to
> the maintainer, he didn't accept it.
>
Vivien,
sorry for asking for an early set of your patches. Obviously the idea was not
to create trouble for anyone :-(. I wasn't aware that netdev only accepts patches
which apply to the latest net-next, even if sent as RFC. My fault, I guess.
Maybe next time we can share patches in private first if we have a similar
situation ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-05-29 22:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 22:29 DSA and underlying 802.1Q encapsulation Vivien Didelot
2015-05-26 22:51 ` Guenter Roeck
2015-05-27 20:48 ` Vivien Didelot
2015-05-27 21:02 ` Guenter Roeck
2015-05-27 21:05 ` Andrew Lunn
2015-05-27 22:51 ` Guenter Roeck
2015-05-28 1:46 ` Andrew Lunn
2015-05-28 5:01 ` Guenter Roeck
2015-05-28 13:44 ` Vivien Didelot
2015-05-28 14:19 ` Guenter Roeck
2015-05-28 21:37 ` [RFC 0/3] DSA and Marvell 88E6352 802.1q support Vivien Didelot
2015-05-28 21:37 ` [RFC 1/3] net: dsa: add basic support for VLAN ndo Vivien Didelot
2015-05-29 4:46 ` Scott Feldman
2015-05-29 15:24 ` Or Gerlitz
2015-05-29 15:38 ` Vivien Didelot
2015-05-29 15:51 ` Or Gerlitz
2015-05-29 22:15 ` Guenter Roeck [this message]
2015-05-29 22:57 ` Vivien Didelot
2015-05-31 16:14 ` Scott Feldman
2015-05-28 21:37 ` [RFC 2/3] net: dsa: mv88e6xxx: add support for VTU operations Vivien Didelot
2015-05-29 22:38 ` Guenter Roeck
2015-05-28 21:37 ` [RFC 3/3] net: dsa: mv88e6352: add support for VLAN Vivien Didelot
2015-05-29 5:02 ` [RFC 0/3] DSA and Marvell 88E6352 802.1q support Scott Feldman
2015-05-29 15:40 ` Vivien Didelot
2015-05-29 22:42 ` Guenter Roeck
2015-05-31 16:48 ` Scott Feldman
2015-05-31 17:06 ` Guenter Roeck
2015-05-31 21:21 ` Scott Feldman
2015-06-02 0:14 ` Florian Fainelli
2015-06-02 0:18 ` Vivien Didelot
2015-06-02 6:18 ` Scott Feldman
2015-06-02 23:23 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568E4FB.6060309@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=andrew@lunn$(echo .)ch \
--cc=cphealy@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gerlitz.or@gmail$(echo .)com \
--cc=jerome.oufella@savoirfairelinux$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox