Subject: Re: [PATCH net-next] bpf: add missing rcu protection when releasing programs from prog_array

From: Daniel Borkmann <[email-masked]>
Date: Sat, 30 May 2015 11:02:32 +0200

On 05/30/2015 01:22 AM, Alexei Starovoitov wrote:
...
> Like __sk_filter_release() and __bpf_prog_release() should be removed.

The whole filter cleanup procedure needs to be simplified a bit, got a
bit too complicated over time, agreed.

> Of course, it's a grey line when to introduce a helper and when not to,
> but just because two lines are close enough between two functions it
> doesn't mean that helper is warranted. In this bpf_prog_put() case
> I think helper is not needed _today_. If it grows, we'll reconsider.

Yes, that's what I meant.