From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: Thomas Graf <tgraf@suug•ch>,
ebiederm@xmission•com, netdev@vger•kernel.org,
Vivek Venkatraman <vivek@cumulusnetworks•com>
Subject: Re: [PATCH WIP RFC 0/3] mpls: support for ler
Date: Fri, 05 Jun 2015 19:54:24 -0700 [thread overview]
Message-ID: <557260E0.9060500@cumulusnetworks.com> (raw)
In-Reply-To: <5571BF90.2070304@brocade.com>
On 6/5/15, 8:26 AM, Robert Shearman wrote:
>
> It isn't clear to me what the strategy here is for dealing with tunnel
> encaps that aren't bound to an interface.
>
> Thomas, I presume you would prefer not to force the user to keep track
> of changes to the output interface and nexthop corresponding to the
> destination of the outer IP header? And I presume that Eric is opposed
> to the option of using a virtual interface here, i.e. falling back to
> the approach I proposed?
>
> In which case, what will the nexthop output interface be set to?
> Logically, it should have no interface. At the moment, the code
> assumes that a nexthop will have a valid interface and I don't have a
> feel for what the impact would be of changing that.
The nexthop interface is the final output interface. Any reason it
should not be ?
>
> However, with that resolved I'd be happy to work on a series together.
> The remaining issue is whether to optimise for small encap that reside
> in the same memory block as the fib_info, which aren't refcounted but
> instead are copied around, or larger encaps that reside in their own
> memory block that are refcounted and only a pointer passed around.
I would prefer the latter (as shown in my incomplete patch) simply
because it stays separate from fib_info and allows for extending it in
the future.
> If the latter, then there really isn't much left in my patch series
> that can be reused, other than references to the places in the code
> that need to be changed to support multipath and to make fib_info
> matching work correctly.
Thanks,
Roopa
next prev parent reply other threads:[~2015-06-06 2:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 14:21 [PATCH WIP RFC 0/3] mpls: support for ler Roopa Prabhu
2015-06-05 9:14 ` Thomas Graf
2015-06-05 14:16 ` roopa
2015-06-05 15:26 ` Robert Shearman
2015-06-06 2:54 ` roopa [this message]
2015-06-08 12:33 ` Thomas Graf
2015-06-08 15:17 ` roopa
2015-06-08 22:58 ` Thomas Graf
2015-06-10 7:13 ` roopa
2015-06-12 16:15 ` roopa
2015-06-05 14:31 ` Robert Shearman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557260E0.9060500@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
--cc=vivek@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox