From: roopa <roopa@cumulusnetworks•com>
To: Scott Feldman <sfeldma@gmail•com>
Cc: Netdev <netdev@vger•kernel.org>,
"ebiederm@xmission•com" <ebiederm@xmission•com>,
rshearma@brocade•com
Subject: Re: /net/mpls/conf/ethX//input duplicate entry
Date: Wed, 10 Jun 2015 14:58:48 -0700 [thread overview]
Message-ID: <5578B318.1050808@cumulusnetworks.com> (raw)
In-Reply-To: <CAE4R7bDhQ3speftJsggqV5Ruh-n0+n_9KR=i0DQYW-NrsUNKZw@mail.gmail.com>
On 6/10/15, 1:43 PM, Scott Feldman wrote:
> I'm getting this dump_stack when reloading rocker driver. Did some
> sysctl MPLS nodes not get cleaned up on NETDEV_UNREGISTER?
>
> Steps to repro: load rocker (on system) with rocker device, rmmod
> rocker, and then modprobe rocker. I doubt this is specific to rocker:
> and re-registration of a netdev should hit it. I am using UDEV rules
> to rename kernel's ethX to a different name. Maybe that's what
> tripped it up?
>
On a quick look, wondering if this is because mpls driver does not seem
to do a unregister and re-register sysctl
on device name change.
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 7b3f732..ec21a5d 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -564,6 +564,14 @@ static int mpls_dev_notify(struct notifier_block
*this, unsigned long event,
case NETDEV_UNREGISTER:
mpls_ifdown(dev);
break;
+ case NETDEV_CHANGENAME:
+ mpls_ifdown(dev);
+ if ((dev->type == ARPHRD_ETHER) ||
+ (dev->type == ARPHRD_LOOPBACK)) {
+ mdev = mpls_add_dev(dev);
+ if (IS_ERR(mdev))
+ return notifier_from_errno(PTR_ERR(mdev));
+ }
}
return NOTIFY_OK;
}
next prev parent reply other threads:[~2015-06-10 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 20:43 /net/mpls/conf/ethX//input duplicate entry Scott Feldman
2015-06-10 21:58 ` roopa [this message]
2015-06-10 23:23 ` Scott Feldman
2015-06-11 12:55 ` Robert Shearman
2015-06-11 15:04 ` roopa
2015-06-11 18:58 ` [PATCH net] mpls: handle device renames for per-device sysctls Robert Shearman
2015-06-11 23:48 ` David Miller
2015-06-11 18:30 ` /net/mpls/conf/ethX//input duplicate entry Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578B318.1050808@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox