Subject: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

From: Florian Fainelli <[email-masked]>
Date: Mon, 15 Jun 2015 10:32:50 -0700

On 12/06/15 11:29, Guenter Roeck wrote:
[snip]

static int dsa_switch_setup_one(struct dsa_switch *ds, struct
>>> device *parent)
>>>   {
>>>       struct dsa_switch_driver *drv = ds->drv;
>>> @@ -204,6 +234,7 @@ static int dsa_switch_setup_one(struct dsa_switch
>>> *ds, struct device *parent)
>>>               }
>>>               dst->cpu_switch = index;
>>>               dst->cpu_port = i;
>>> +            ds->cpu_port_mask |= 1 << i;
>>
>> Same question as Guenter here, I assume this is because you plan on
>> having multiple CPU ports connected to the switch and this makes it
>> easier to deal with, is that right?
>>
> 
> If so, should that be done in a separate patch set ?

I think it would be clearer that way, yes.
-- 
Florian