From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Oliver Hartkopp <socketcan@hartkopp•net>,
Stephen Hemminger <stephen@networkplumber•org>
Cc: Ulrich Gemkow <ulrich.gemkow@ikr•uni-stuttgart.de>,
netdev@vger•kernel.org, David Miller <davem@davemloft•net>
Subject: Re: displayed name changed in ip link show for bridge- and other interfaces
Date: Wed, 17 Jun 2015 09:26:05 +0200 [thread overview]
Message-ID: <5581210D.5070901@6wind.com> (raw)
In-Reply-To: <55805E6A.90805@hartkopp.net>
Le 16/06/2015 19:35, Oliver Hartkopp a écrit :
> On 15.06.2015 17:54, Stephen Hemminger wrote:
>> On Mon, 15 Jun 2015 11:13:12 +0200
>> Nicolas Dichtel <nicolas.dichtel@6wind•com> wrote:
>>
>>> Theoretically, virtual interfaces should advertise an IFLA_LINK to 0.
>>> I don't know what is the best fix:
>>> - patching iproute2 to avoid this '@NONE'
>>> - patching the kernel (see below).
>>
>>
>> Sorry this is an ABI change. The kernel has to go back
>> to doing the same thing as before.
>>
>
> Isn't this too late right now at 4.1-rc8 stage???
>
> At least the patch suggested for br_device.c at
>
> http://marc.info/?l=linux-netdev&m=143435960111768&w=2
>
> would been necessary in all networking drivers, right?
>
> I currently see this @NONE stuff with virtual CAN devices too.
Another solution is to revert e1622baf54df ("dev: set iflink to 0 for virtual
interfaces") and add a ndo_get_iflink handler which returns 0 for all virtual
interfaces that had this IFLA_LINK set to 0 before the series.
But it's not consistent between virtual interfaces.
next prev parent reply other threads:[~2015-06-17 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 10:00 displayed name changed in ip link show for bridge- and other interfaces Ulrich Gemkow
2015-06-14 18:50 ` Oliver Hartkopp
2015-06-14 19:12 ` Oliver Hartkopp
2015-06-15 7:23 ` Nicolas Dichtel
2015-06-15 9:13 ` Nicolas Dichtel
2015-06-15 15:54 ` Stephen Hemminger
2015-06-16 17:35 ` Oliver Hartkopp
2015-06-16 17:47 ` Oliver Hartkopp
2015-06-17 7:26 ` Nicolas Dichtel [this message]
2015-06-20 22:58 ` Oliver Hartkopp
2015-06-23 12:48 ` Nicolas Dichtel
2015-06-23 17:21 ` Oliver Hartkopp
2015-07-06 15:25 ` [PATCH net] Revert "dev: set iflink to 0 for virtual interfaces" Nicolas Dichtel
2015-07-06 16:38 ` Oliver Hartkopp
2015-07-07 7:44 ` [PATCH net v2] " Nicolas Dichtel
2015-07-08 22:52 ` [PATCH net] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581210D.5070901@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=socketcan@hartkopp$(echo .)net \
--cc=stephen@networkplumber$(echo .)org \
--cc=ulrich.gemkow@ikr$(echo .)uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox