From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: ebiederm@xmission•com, tgraf@suug•ch, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels
Date: Sat, 20 Jun 2015 07:42:09 -0700 [thread overview]
Message-ID: <55857BC1.6010704@cumulusnetworks.com> (raw)
In-Reply-To: <55843E15.2040301@brocade.com>
On 6/19/15, 9:06 AM, Robert Shearman wrote:
>> +
>> + /* Push the new labels */
>> + hdr = mpls_hdr(skb);
>> + bos = true;
>> + for (i = tun_encap_info->labels - 1; i >= 0; i--) {
>> + hdr[i] = mpls_entry_encode(tun_encap_info->label[i],
>> + dec.ttl, 0, bos);
>
> dec is never initialised in this function, so this will encode a
> garbage ttl into the packet.
>
> This should instead be deriving the ttl from the IP packet, as Eric
> did in his original patch.
>
Thanks for the pointer Robert. I will fix it.
next prev parent reply other threads:[~2015-06-20 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels Roopa Prabhu
2015-06-19 16:06 ` Robert Shearman
2015-06-20 14:41 ` roopa
2015-06-20 14:42 ` roopa [this message]
2015-06-21 20:27 ` Thomas Graf
2015-06-22 2:35 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55857BC1.6010704@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox