Subject: Re: [PATCH 2/3] rcar_can: print signed IRQ #

From: Marc Kleine-Budde <[email-masked]>
Date: Sat, 20 Jun 2015 18:02:19 +0200

On 06/20/2015 04:38 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 6/20/2015 3:03 PM, Geert Uytterhoeven wrote:
> 
>>> Printing IRQ # using "%x" and "%u" unsigned formats isn't quite correct as
>>> 'ndev->irq' is of  type *int*, so  the "%d" format  needs to be used instead.
> 
>>> While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.
> 
>> If you change the message, why don't you make it consistent
>> ("interrupt" vs. "IRQ")?
> 
>     I decided to change the message in a follow-up patch (posted afterwards).

Please squash you patches, so that you don't modify code (or error
messages) that you've added in a previous patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |