From: Or Gerlitz <ogerlitz@mellanox•com>
To: David Miller <davem@davemloft•net>, <achiad.mellanox@gmail•com>
Cc: <netdev@vger•kernel.org>, <amirv@mellanox•com>,
<talal@mellanox•com>, <saeedm@mellanox•com>
Subject: Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency
Date: Tue, 23 Jun 2015 17:12:54 +0300 [thread overview]
Message-ID: <55896966.80704@mellanox.com> (raw)
In-Reply-To: <20150622.063554.1081040359354241131.davem@davemloft.net>
On 6/22/2015 4:35 PM, David Miller wrote:
> From: achiad shochat <achiad.mellanox@gmail•com>
> Date: Mon, 22 Jun 2015 00:35:37 +0300
>
>> Hello Dave,
>>
>> In mlx5 the RX processing is broken down into two stages:
>> 1) Hand to kernel SKBs of completed RX packets - @mlx5e_poll_rx_cq()
>> 2) Allocate and post to HW new RX buffers - @mlx5e_post_rx_wqes()
>>
>> Would handling of TX completions in between stages (1) and (2) be OK?
> I would do all of TX processing first and synchronously. It's very
> cheap and makes lots of resources available for RX processing.
So we'll drop this patch.
Or.
next prev parent reply other threads:[~2015-06-23 14:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 15:26 [PATCH net-next 00/12] Mellanox NIC drivers update, Jun 17 2015 Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 01/12] net/mlx4_en: Fix off-by-four in ethtool Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 02/12] net/mlx4_en: Use HW counters for rx/tx bytes/packets in PF device Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 03/12] net/mlx5e: Static mapping of netdev priv resources to/from netdev TX queues Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 04/12] net/mlx5e: Use skb_shinfo(skb)->gso_segs rather than counting them Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency Or Gerlitz
2015-06-21 17:21 ` David Miller
2015-06-21 21:35 ` achiad shochat
2015-06-22 13:35 ` David Miller
2015-06-23 14:12 ` Or Gerlitz [this message]
2015-06-17 15:26 ` [PATCH net-next 06/12] net/mlx5e: Remove re-assignment of wq type in mlx5e_enable_rq() Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 07/12] net/mlx5e: Avoid redundant dev_kfree_skb() upon NOP completion Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 08/12] net/mlx5e: Avoid TX CQE generation if more xmit packets expected Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 09/12] net/mlx5e: Remove extra spaces Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 10/12] net/mlx5e: Remove mlx5e_cq.sqrq back-pointer Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 11/12] net/mlx5e: Pop cq outside mlx5e_get_cqe Or Gerlitz
2015-06-17 15:26 ` [PATCH net-next 12/12] net/mlx5e: Prefetch skb data on RX Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55896966.80704@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=achiad.mellanox@gmail$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saeedm@mellanox$(echo .)com \
--cc=talal@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox