Subject: Re: [PATCH net] net_sched: gen_estimator: extend pps limit

From: Alexei Starovoitov <[email-masked]>
Date: Thu, 02 Jul 2015 10:15:56 -0700

On 7/2/15 6:57 AM, Eric Dumazet wrote:
> From: Eric Dumazet<[email-masked]>
>
> rate estimators are limited to 4 Mpps, which was fine years ago, but
> too small with current hardware generation.
>
> Lets use 2^5 scaling instead of 2^10 to get 128 Mpps new limit.
>
> On 64bit arch, use an "unsigned long" for temp storage and remove limit.
> (We do not expect 32bit arches to be able to reach this point)
>
> Tested:
>
> tc -s -d filter sh dev eth0 parent ffff:
>
> filter protocol ip pref 1 u32
> filter protocol ip pref 1 u32 fh 800: ht divisor 1
> filter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:15
>    match 07000000/ff000000 at 12
> 	action order 1: gact action drop
> 	 random type none pass val 0
> 	 index 1 ref 1 bind 1 installed 166 sec
>   	Action statistics:
> 	Sent 39734251496 bytes 863788076 pkt (dropped 863788117, overlimits 0 requeues 0)
> 	rate 4067Mbit 11053596pps backlog 0b 0p requeues 0
>
> Signed-off-by: Eric Dumazet<[email-masked]>

Looks good to me.
Acked-by: Alexei Starovoitov <[email-masked]>