From: Alexei Starovoitov <ast@plumgrid•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
David Miller <davem@davemloft•net>
Cc: netdev <netdev@vger•kernel.org>,
Jamal Hadi Salim <jhs@mojatatu•com>,
John Fastabend <john.fastabend@gmail•com>
Subject: Re: [PATCH net-next] ifb: add multiqueue operation
Date: Mon, 06 Jul 2015 17:19:59 -0700 [thread overview]
Message-ID: <559B1B2F.5050300@plumgrid.com> (raw)
In-Reply-To: <1436213128.4571.14.camel@edumazet-glaptop2.roam.corp.google.com>
On 7/6/15 1:05 PM, Eric Dumazet wrote:
> Add multiqueue capabilities to ifb netdevice.
>
> This removes last bottleneck for ingress when mq qdisc can be used
> to shard load from multiple RX queues on physical device.
...
> Signed-off-by: Eric Dumazet<edumazet@google•com>
> Cc: Alexei Starovoitov<ast@plumgrid•com>
> Cc: Jamal Hadi Salim<jhs@mojatatu•com>
> Cc: John Fastabend<john.fastabend@gmail•com>
> ---
> drivers/net/ifb.c | 207 +++++++++++++++++++++++++-------------------
> 1 file changed, 120 insertions(+), 87 deletions(-)
...
> -struct ifb_private {
> +struct ifb_q_private {
...
> -};
> +} ____cacheline_aligned_in_smp;
...
> +static int ifb_dev_init(struct net_device *dev)
> +{
> + struct ifb_dev_private *dp = netdev_priv(dev);
> + struct ifb_q_private *txp;
> + int i;
> +
> + txp = kcalloc(dev->num_tx_queues, sizeof(*txp), GFP_KERNEL);
...
> static netdev_tx_t ifb_xmit(struct sk_buff *skb, struct net_device *dev)
> {
> - struct ifb_private *dp = netdev_priv(dev);
> + struct ifb_dev_private *dp = netdev_priv(dev);
> u32 from = G_TC_FROM(skb->tc_verd);
> + struct ifb_q_private *txp = dp->tx_private + skb_get_queue_mapping(skb);
All makes sense. Nicely done!
Acked-by: Alexei Starovoitov <ast@plumgrid•com>
next prev parent reply other threads:[~2015-07-07 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 20:05 [PATCH net-next] ifb: add multiqueue operation Eric Dumazet
2015-07-07 0:19 ` Alexei Starovoitov [this message]
2015-07-08 12:29 ` Jamal Hadi Salim
2015-07-08 13:06 ` Eric Dumazet
2015-07-08 23:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B1B2F.5050300@plumgrid.com \
--to=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox