Subject: Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

From: Nicolas Dichtel <[email-masked]>
Date: Wed, 08 Jul 2015 11:43:50 +0200

Le 07/07/2015 19:56, Andy Gospodarek a écrit :
> This kernel patch exports the value of the new
> ignore_routes_with_linkdown via netconf.
>
> v2: changes to notify userspace via netlink when sysctl values change
> and proposed for 'net' since this could be considered a bugfix
Hmm, commit title contains net-next, not net.

>
> Signed-off-by: Andy Gospodarek <[email-masked]>
> Suggested-by: Nicolas Dichtel <[email-masked]>
Acked-by: Nicolas Dichtel <[email-masked]>

> ---
> I realize two of these changes result in lines >80 chars, but this is to
> keep the coding-style used by the surrounding code.
>
> There are multiple ways to resolve this, but one would be to shorten the
> defines used for this feature as "IGNORE_ROUTES_WITH_LINKDOWN" is a
> mouthful.  I would propose dropping "_WITH_" from all the defines and
> have only "IGNORE_ROUTES_LINKDOWN" everywhere.  Doing this now in 'net'
Yes. Or even shorter: IGNORE_NH_LINKDOWN?

> would be ideal before a release happens and it cannot be changed.
Yes.