Subject: Re: [PATCH net-next 2/5] net: add phys ID compare helper to test if two IDs are the same

From: Sergei Shtylyov <[email-masked]>
Date: Thu, 9 Jul 2015 15:15:35 +0300

Hello.

On 7/9/2015 2:16 AM, [email-masked] wrote:

> From: Scott Feldman <[email-masked]>

> Signed-off-by: Scott Feldman <[email-masked]>
> ---
>   include/linux/netdevice.h |    7 +++++++
>   net/switchdev/switchdev.c |    8 ++------
>   2 files changed, 9 insertions(+), 6 deletions(-)

[...]
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 84f77a0..e16586f 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -906,13 +906,9 @@ static struct net_device *switchdev_get_dev_by_nhs(struct fib_info *fi)
>   		if (switchdev_port_attr_get(dev, &attr))
>   			return NULL;
>
> -		if (nhsel > 0) {
> -			if (prev_attr.u.ppid.id_len != attr.u.ppid.id_len)
> +		if (nhsel > 0 &&
> +		    !netdev_phys_item_id_same(&prev_attr.u.ppid, &attr.u.ppid))
>   				return NULL;

    This line should be re-indented now, it starts too far to the right.

[...]

WBR, Sergei