Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

From: roopa <roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public•gmane.org>
To: Thomas Graf <tgraf-G/eBtMaohhA@public•gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public•gmane.org,
	marcelo.leitner-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org,
	jiri-rHqAuBHg3fBzbRFIqnYvSA@public•gmane.org,
	daniel-FeC+5ew28dpmcu3hnIyYJQ@public•gmane.org,
	Eric Dumazet
	<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
	tom-BjP2VixgY4xUbtYUoyoikg@public•gmane.org,
	edumazet-hpIqsD4AKlfQT0dZR+AlfA@public•gmane.org,
	kaber-dcUjhNyLwpNeoWH0uzbU5w@public•gmane.org,
	stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public•gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public•gmane.org,
	hannes-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public•gmane.org,
	rshearma-43mecJUBy8ZBDgjK7y7TUQ@public•gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org
Subject: Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes
Date: Fri, 10 Jul 2015 09:56:56 -0700	[thread overview]
Message-ID: <559FF958.1020403@cumulusnetworks.com> (raw)
In-Reply-To: <20150710165436.GC11654-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>

On 7/10/15, 9:54 AM, Thomas Graf wrote:
> On 07/10/15 at 05:36pm, Eric Dumazet wrote:
>> On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote:
>>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>>> +	if (oif)
>>> +		dev = __dev_get_by_index(net, oif);
>>> +	ret = lwtunnel_build_state(dev, encap_type,
>>> +				   encap, &lwtstate);
>>> +	if (!ret) {
>>> +		lwtunnel_state_get(lwtstate);
>>> +		ret = lwtunnel_cmp_encap(lwtstate, nh->nh_lwtstate);
>>> +		lwtunnel_state_put(lwtstate);
>>> +
>>> +		return ret;
>>
>> These _get()/_put() calls do not seem necessary, or buggy.
>>
>> If refcounting is needed the _get() should be done at the time lwstate
>> is fetched.
> I'll let Roopa comment but it seems like these can just be removed.
Agree, They do seem unnecessary here.  I will get rid of them. thanks.
_______________________________________________
dev mailing list
dev@openvswitch•org
http://openvswitch.org/mailman/listinfo/dev