From: Chris Metcalf <cmetcalf@ezchip•com>
To: Frederic Weisbecker <fweisbec@gmail•com>
Cc: <netdev@vger•kernel.org>, <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] nohz: prevent tilegx network driver interrupts
Date: Fri, 10 Jul 2015 15:05:02 -0400 [thread overview]
Message-ID: <55A0175E.2010200@ezchip.com> (raw)
In-Reply-To: <20150710182406.GC26428@lerouge>
On 07/10/2015 02:24 PM, Frederic Weisbecker wrote:
> On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote:
>> In nohz_full mode, by default distribute networking shim
>> interrupts across the housekeeping cores, not all the cores.
> I can't really tell, I have no idea what this driver does. It seems
> to be about networking CPUs but I have no idea what we are affining
> here. Whether it is task, interrupt, ... And what those affine things do,
> if it is safe to do that reduce affinity etc..
>
> I looked at the driver but I can't make my way there. I think you
> need a more detailed changelog :-)
Fair enough! :-) See updated changelog to follow.
>> Signed-off-by: Chris Metcalf <cmetcalf@ezchip•com>
>> ---
>> The alternate approaches to this might be:
>>
>> 1. "#define housekeeping_mask cpu_online_mask" in the non-nohz_full
>> arm in <linux/tick.h>, then just unconditionally use
>> "housekeeping_mask".
> Indeed we are doing more and more references on housekeeping_mask, so
> we should probably think about an off-case.
>
> Now the nohz-full off-case should rather be cpu_possible_mask than
> cpu_online_mask. housekeeping_mask doesn't take into account onlining
> at all.
That suggests that in this case, we might want to default to
something like "housekeeping_mask & cpu_online_mask",
since you really don't want to send irqs to offline cores to
process your packets :-)
The tilegx chips typically don't do cpu offlining anyway, since
we've never really found a usecase, so whatever you boot with
you always have available. We do have support for a bare-metal
mode which you can run on some of the cores, so you may start
with fewer than cpu_possible actually running, but it will always
be that same set of cores.
So this does suggest that my original patch is wrong for that
same reason.
>> 2. Provide an accessor that returns the cpumask to use for housekeeping
>> chores and implement it in the obvious ways for both nohz_full
>> and non-nohz_full.
>>
>> The latter seems like arguably the most satisfying approach, but
>> the patch below is, if nothing else, suitable to push for 4.3
>> without any further API development work.
> I don't know. 1) looks easier.
On reflection, the problem with (1) is that if you are in NO_HZ_FULL
mode but !tick_nohz_full_enabled(), you want to fall back to just
using cpu_possible_mask anyway. So I think a simple accessor that
returns an appropriate cpumask pointer is probably the best bet
(along the lines of the existing is_housekeeping_cpu() accessor).
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
next prev parent reply other threads:[~2015-07-10 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 17:33 [PATCH] nohz: prevent tilegx network driver interrupts Chris Metcalf
2015-07-10 18:24 ` Frederic Weisbecker
2015-07-10 19:05 ` Chris Metcalf [this message]
2015-07-10 19:37 ` [PATCH v2] " Chris Metcalf
2015-07-10 22:45 ` Josh Cartwright
2015-07-10 23:06 ` Chris Metcalf
2015-07-10 23:12 ` Josh Cartwright
2015-07-11 14:44 ` Frederic Weisbecker
2015-07-11 15:04 ` Chris Metcalf
2015-07-11 14:30 ` [PATCH] " Frederic Weisbecker
2015-07-20 21:22 ` Chris Metcalf
2015-07-20 21:49 ` Frederic Weisbecker
2015-07-20 22:15 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A0175E.2010200@ezchip.com \
--to=cmetcalf@ezchip$(echo .)com \
--cc=fweisbec@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox