From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>, davem@davemloft•net
Cc: Mitch Williams <mitch.a.williams@intel•com>,
netdev@vger•kernel.org, nhorman@redhat•com, sassmann@redhat•com,
jogreene@redhat•com
Subject: Re: [net-next 12/16] i40evf: don't delete all the filters
Date: Mon, 13 Jul 2015 15:51:08 +0300 [thread overview]
Message-ID: <55A3B43C.5010806@cogentembedded.com> (raw)
In-Reply-To: <1436778517-16254-13-git-send-email-jeffrey.t.kirsher@intel.com>
Hello.
On 7/13/2015 12:08 PM, Jeff Kirsher wrote:
> From: Mitch Williams <mitch.a.williams@intel•com>
> Due to an inverted conditional, the driver was marking all of its MAC
> filters for deletion every time set_rx_mode was called. Depending upon
> the timing of the calls to set_rx_mode and the processing of the admin
> queue, the driver would (accidentally) end up with a varying number of
> functional filters.
> Correct this logic so that MAC filters are added and removed correctly.
> Add a check for the driver's "hardware" MAC address so that this filter
> doesn't get removed incorrectly.
> Change-ID: Ib3e7c4a5b53df6835f164fe44cb778cb71f8aff8
> Signed-off-by: Mitch Williams <mitch.a.williams@intel•com>
> Tested-by: Jim Young <james.m.young@intel•com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> ---
> drivers/net/ethernet/intel/i40evf/i40evf_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> index 94eff4a..07f6052 100644
> --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> @@ -892,8 +892,10 @@ static void i40evf_set_rx_mode(struct net_device *netdev)
> break;
> }
> }
> + if (ether_addr_equal(f->macaddr, adapter->hw.mac.addr))
> + found = true;
This line is indented too much.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-07-13 12:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 9:08 [net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-07-13 Jeff Kirsher
2015-07-13 9:08 ` [net-next 01/16] i40e: Implement ndo_features_check() Jeff Kirsher
2015-07-13 9:08 ` [net-next 02/16] i40e/i40evf: Add stats to track FD ATR and SB dynamic enable state Jeff Kirsher
2015-07-13 9:08 ` [net-next 03/16] i40e/i40evf: Update Flex-10 related device/function capabilities Jeff Kirsher
2015-07-13 9:08 ` [net-next 04/16] i40e/i40evf: improve Tx performance with a small tweak Jeff Kirsher
2015-07-13 9:08 ` [net-next 05/16] i40evf: Allow for an abundance of vectors Jeff Kirsher
2015-07-13 9:08 ` [net-next 06/16] i40e: ignore duplicate port VLAN requests Jeff Kirsher
2015-07-13 9:08 ` [net-next 07/16] i40e: Remove incorrect #ifdef's Jeff Kirsher
2015-07-13 9:08 ` [net-next 08/16] i40e/i40evf: Update the admin queue command header Jeff Kirsher
2015-07-13 9:08 ` [net-next 09/16] i40e: correctly program filters for VFs Jeff Kirsher
2015-07-13 9:08 ` [net-next 10/16] i40e: do a proper reset when disabling a VF Jeff Kirsher
2015-07-13 9:08 ` [net-next 11/16] i40e: un-disable VF after reset Jeff Kirsher
2015-07-13 9:08 ` [net-next 12/16] i40evf: don't delete all the filters Jeff Kirsher
2015-07-13 12:51 ` Sergei Shtylyov [this message]
2015-07-13 9:08 ` [net-next 13/16] i40evf: add MAC address filter in open, not init Jeff Kirsher
2015-07-13 9:08 ` [net-next 14/16] i40e/i40evf: Add support for pre-allocated pages for PD Jeff Kirsher
2015-07-13 9:08 ` [net-next 15/16] i40e: Refine an error message to avoid confusion Jeff Kirsher
2015-07-13 9:08 ` [net-next 16/16] i40e/i40evf: Bump version to 1.3.6 for i40e and 1.3.2 for i40evf Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3B43C.5010806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jogreene@redhat$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@redhat$(echo .)com \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox