Subject: Re: [net-next v2 06/16] i40e: ignore duplicate port VLAN requests

From: Sergei Shtylyov <[email-masked]>
Date: Wed, 15 Jul 2015 22:24:50 +0300

Hello.

On 07/15/2015 04:30 AM, Jeff Kirsher wrote:

> From: Mitch Williams <[email-masked]>

> If user attempts to set a port VLAN on a VF that already has the same
> port VLAN configured, the driver will go through a completely
> unnecessary flurry of filter removals and filter adds. Just check for
> this condition and return success instead of doing a bunch of busywork.

> Change-ID: Ia1a9e83e6ed48b3f4658bc20dfc6af0cf525d54a
> Signed-off-by: Mitch Williams <[email-masked]>
> Tested-by: Jim Young <[email-masked]>
> Signed-off-by: Jeff Kirsher <[email-masked]>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 4 ++++
>   1 file changed, 4 insertions(+)

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 23f95cd..433e803 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -2088,6 +2088,10 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev,
>   		goto error_pvid;
>   	}
>
> +	if (vsi->info.pvid == (vlan_id | (qos << I40E_VLAN_PRIORITY_SHIFT)))

    Parens around | not necessary (strictly speaking, around << too but gcc 
may have another opinion and warn about the parens).

[...]

MBR, Sergei