From: Stas Sergeev <stsp@list•ru>
To: netdev <netdev@vger•kernel.org>
Cc: Linux kernel <linux-kernel@vger•kernel.org>,
Sebastien Rannou <mxs@sbrk•org>,
Arnaud Ebalard <arno@natisbad•org>,
Stas Sergeev <stsp@users•sourceforge.net>,
Florian Fainelli <f.fainelli@gmail•com>
Subject: [PATCH 1/3] fixed_phy: handle link-down case
Date: Thu, 16 Jul 2015 17:50:06 +0300 [thread overview]
Message-ID: <55A7C49E.2020803@list.ru> (raw)
In-Reply-To: <55A7C45F.1070501@list.ru>
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
It fixes the status registers when link is down, and also allows
to register the fixed-phy with link down without specifying the speed.
Signed-off-by: Stas Sergeev <stsp@users•sourceforge.net>
CC: Florian Fainelli <f.fainelli@gmail•com>
CC: netdev@vger•kernel.org
CC: linux-kernel@vger•kernel.org
---
drivers/net/phy/fixed_phy.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index 1960b46..479b93f 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c
@@ -52,6 +52,10 @@ static int fixed_phy_update_regs(struct fixed_phy *fp)
u16 lpagb = 0;
u16 lpa = 0;
+ if (!fp->status.link)
+ goto done;
+ bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE;
+
if (fp->status.duplex) {
bmcr |= BMCR_FULLDPLX;
@@ -96,15 +100,13 @@ static int fixed_phy_update_regs(struct fixed_phy *fp)
}
}
- if (fp->status.link)
- bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE;
-
if (fp->status.pause)
lpa |= LPA_PAUSE_CAP;
if (fp->status.asym_pause)
lpa |= LPA_PAUSE_ASYM;
+done:
fp->regs[MII_PHYSID1] = 0;
fp->regs[MII_PHYSID2] = 0;
--
1.9.1
next prev parent reply other threads:[~2015-07-16 14:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 14:49 [PATCH v4 0/3] net: enable inband link state negotiation only when explicitly requested Stas Sergeev
2015-07-16 14:50 ` Stas Sergeev [this message]
2015-07-16 23:25 ` [PATCH 1/3] fixed_phy: handle link-down case Florian Fainelli
2015-07-17 11:26 ` Stas Sergeev
2015-07-17 18:50 ` Florian Fainelli
2015-07-17 20:03 ` Stas Sergeev
2015-07-17 22:01 ` Florian Fainelli
2015-07-17 23:24 ` Stas Sergeev
2015-07-17 23:35 ` Florian Fainelli
2015-07-17 23:53 ` Stas Sergeev
2015-07-18 2:29 ` Florian Fainelli
2015-07-18 21:16 ` Stas Sergeev
[not found] ` <55A7C45F.1070501-cmBhpYW9OiY@public.gmane.org>
2015-07-16 14:52 ` [PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type Stas Sergeev
2015-07-16 14:53 ` [PATCH 3/3] mvneta: use inband status only when explicitly enabled Stas Sergeev
-- strict thread matches above, loose matches on Subject: below --
2015-07-14 17:09 [PATCH v3 0/3] net: enable inband link state negotiation only when explicitly requested Stas Sergeev
2015-07-14 17:11 ` [PATCH 1/3] fixed_phy: handle link-down case Stas Sergeev
2015-07-14 18:28 ` Florian Fainelli
2015-07-10 16:38 [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested Stas Sergeev
2015-07-10 16:41 ` [PATCH 1/3] fixed_phy: handle link-down case Stas Sergeev
2015-07-10 20:44 ` Florian Fainelli
2015-07-10 21:14 ` Stas Sergeev
2015-07-11 0:15 ` Florian Fainelli
2015-07-11 8:58 ` Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A7C49E.2020803@list.ru \
--to=stsp@list$(echo .)ru \
--cc=arno@natisbad$(echo .)org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mxs@sbrk$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stsp@users$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox