Subject: Re: [PATCH] genet:Return the variable ret rather then zero for the function bcmgenet_power_down

From: Florian Fainelli <[email-masked]>
Date: Thu, 16 Jul 2015 12:24:53 -0700

On 15/07/15 08:09, Nicholas Krause wrote:
> This makes the function bcmgenet_power_down return the variable ret
> rather then zero in order to make this function be able to signal its
> caller with a error code when a failure occurs internally rather then
> always appearing to run successfully to its caller.

Please adjust the subject to be "net: bcmgenet: blah blah", just to
conform to the style used for all other changes.

This seems fine otherwise...

> 
> Signed-off-by: Nicholas Krause <[email-masked]>
> ---
>  drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 64c1e9d..129e5b5 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -877,7 +877,7 @@ static int bcmgenet_power_down(struct bcmgenet_priv *priv,
>  		break;
>  	}
>  
> -	return 0;
> +	return ret;
>  }
>  
>  static void bcmgenet_power_up(struct bcmgenet_priv *priv,
> 

-- 
Florian