From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Hariprasad Shenai <hariprasad@chelsio•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, leedom@chelsio•com, nirranjan@chelsio•com
Subject: Re: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access
Date: Mon, 20 Jul 2015 15:13:33 +0300 [thread overview]
Message-ID: <55ACE5ED.1030304@cogentembedded.com> (raw)
In-Reply-To: <1437404051-7020-1-git-send-email-hariprasad@chelsio.com>
Hello.
On 7/20/2015 5:54 PM, Hariprasad Shenai wrote:
> Add debugfs entry 'use_backdoor' to enable/disable backdoor access
> to read sge context. By default, we read sge context's via firmware. In
> case of FW issues, one can enable backdoor access via debugfs to dump
> sge context for debugging purpose.
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio•com>
[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> index b135d05..5b525a7 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
> @@ -2386,8 +2386,11 @@ int t4_setup_debugfs(struct adapter *adap)
> EXT_MEM_SIZE_G(size));
> }
>
> - de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root, adap,
> - &flash_debugfs_fops, adap->params.sf_size);
> + de = debugfs_create_file_size("flash", S_IRUSR, adap->debugfs_root,
> + adap, &flash_debugfs_fops,
> + adap->params.sf_size);
What was the point reformatting this call?
[...]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> index 1e6597d..f8f446e 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
> @@ -3689,6 +3689,11 @@ int t4_read_rss(struct adapter *adapter, u16 *map)
> return 0;
> }
>
> +static unsigned int t4_use_ldst(struct adapter *adap)
> +{
> + return (adap->flags & FW_OK) || (!adap->use_bd);
Second parens not neeeded.
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-07-20 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:54 [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access Hariprasad Shenai
2015-07-20 12:13 ` Sergei Shtylyov [this message]
2015-07-20 13:03 ` Hariprasad S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACE5ED.1030304@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hariprasad@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nirranjan@chelsio$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox