Subject: Re: drivers/net/phy/dp83867.c:167: possible bad if ?

From: Florian Fainelli <[email-masked]>
Date: Mon, 20 Jul 2015 10:28:38 -0700

Adding Dan,

On 20/07/15 05:37, David Binderman wrote:
> Hello there,
> 
> drivers/net/phy/dp83867.c:167:57: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op]
> 
> Source code is
> 
>     if ((phydev->interface>= PHY_INTERFACE_MODE_RGMII_ID) ||
>         (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
> 
> Maybe
> 
>     if ((phydev->interface>= PHY_INTERFACE_MODE_RGMII_ID) &&
>         (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {

Sounds like the former is the intended comparison that will make sure
that phydev->interface is between MODE_RGMII_ID and MODE_RGMII_RXID, and
not below or after.
-- 
Florian