From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
To: Cong Wang <cwang@twopensource•com>
Cc: netdev <netdev@vger•kernel.org>,
"bridge@lists•linux-foundation.org"
<bridge@lists•linux-foundation.org>,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH net-next] bridge: mcast: when multicast is disabled flush the groups
Date: Wed, 22 Jul 2015 20:01:45 +0200 [thread overview]
Message-ID: <55AFDA89.1080304@cumulusnetworks.com> (raw)
In-Reply-To: <CAHA+R7PTV5aTk2JyaaCQ1awi_Cwz+jzA4tv9n2nEvaFxhuD0Pg@mail.gmail.com>
On 07/22/2015 07:03 PM, Cong Wang wrote:
> On Wed, Jul 22, 2015 at 3:28 AM, Nikolay Aleksandrov
> <nikolay@cumulusnetworks•com> wrote:
>> From: Satish Ashok <sashok@cumulusnetworks•com>
>>
>> Once multicast gets disabled we should flush the groups.
>> Example:
>> # bridge mdb add dev br0 port eth3 grp 239.0.0.1
>> # bridge mdb
>> dev br0 port eth3 grp 239.0.0.1 temp
>> # echo 0 > multicast_snooping
>> # bridge mdb
>
> Why? Why we can't save the mdb config for a mcast snooping flip?
>
Right, I've discussed this with my colleagues and we think this doesn't have any
value for upstream and shouldn't have been sent which is bad judgment on my side.
It actually makes things worse because it removes the user's permanent entries on
snooping disable and it may happen automatically by hash exhaustion.
Anyway, please drop this patch and sorry for the noise, I should've given this
change more thought.
Thanks,
Nik
prev parent reply other threads:[~2015-07-22 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 10:28 [PATCH net-next] bridge: mcast: when multicast is disabled flush the groups Nikolay Aleksandrov
2015-07-22 17:03 ` Cong Wang
2015-07-22 18:01 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AFDA89.1080304@cumulusnetworks.com \
--to=nikolay@cumulusnetworks$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox