From: David Ahern <dsa@cumulusnetworks•com>
To: Alexander Duyck <alexander.h.duyck@redhat•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org
Subject: Re: [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix
Date: Mon, 27 Jul 2015 15:02:07 -0600 [thread overview]
Message-ID: <55B69C4F.40506@cumulusnetworks.com> (raw)
In-Reply-To: <20150727195631.26840.93266.stgit@ahduyck-vm-fedora22>
On 7/27/15 2:08 PM, Alexander Duyck wrote:
> It was reported that update_suffix was taking a long time on systems where
> a large number of leaves were attached to a single node. As it turns out
> fib_table_flush was calling update_suffix for each leaf that didn't have all
> of the aliases stripped from it. As a result, on this large node removing
> one leaf would result in us calling update_suffix for every other leaf on
> the node.
>
> The fix is to just remove the calls to leaf_pull_suffix since they are
> redundant as we already have a call in resize that will go through and
> update the suffix length for the node before we exit out of
> fib_table_flush or fib_table_flush_external.
>
> Reported-by: David Ahern<dsa@cumulusnetworks•com>
> Signed-off-by: Alexander Duyck<alexander.h.duyck@redhat•com>
> ---
>
> This patch should apply to linux-4.1.y and newer kernels.
>
> I've done a bit of testing on my system and I no longer see update_suffix
> dominating the performance traces. David if you can test with this patch
> to see if you still see the issue I would appreciate it.
>
Works for me. Thanks.
Tested-by: David Ahern <dsa@cumulusnetworks•com>
next prev parent reply other threads:[~2015-07-27 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 16:49 increase in time to delete an interface with 4.x kernels David Ahern
2015-07-27 17:36 ` Alexander Duyck
2015-07-27 20:08 ` [net PATCH] fib_trie: Drop unnecessary calls to leaf_pull_suffix Alexander Duyck
2015-07-27 21:02 ` David Ahern [this message]
2015-07-27 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B69C4F.40506@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=alexander.h.duyck@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox